This repository was archived by the owner on May 25, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 385
fix: add None guard for params in get_balance_allowance and update_balance_allowance #307
Open
Sush78
wants to merge
1
commit into
Polymarket:main
Choose a base branch
from
Sush78:fix/balance-allowance-none-guard
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| from unittest import TestCase | ||
|
|
||
| from py_clob_client.client import ClobClient | ||
| from py_clob_client.clob_types import ApiCreds | ||
| from py_clob_client.constants import AMOY | ||
|
|
||
| # publicly known private key | ||
| private_key = "0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80" | ||
| creds = ApiCreds( | ||
| api_key="test-api-key", | ||
| api_secret="test-api-secret", | ||
| api_passphrase="test-api-passphrase", | ||
| ) | ||
|
|
||
|
|
||
| class TestBalanceAllowance(TestCase): | ||
| def test_get_balance_allowance_requires_params(self): | ||
| client = ClobClient( | ||
| "https://clob.polymarket.com", | ||
| key=private_key, | ||
| chain_id=AMOY, | ||
| creds=creds, | ||
| ) | ||
| with self.assertRaises(ValueError): | ||
| client.get_balance_allowance() | ||
|
|
||
| def test_update_balance_allowance_requires_params(self): | ||
| client = ClobClient( | ||
| "https://clob.polymarket.com", | ||
| key=private_key, | ||
| chain_id=AMOY, | ||
| creds=creds, | ||
| ) | ||
| with self.assertRaises(ValueError): | ||
| client.update_balance_allowance() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.