docs: fix matchOrders parameter order and types in Overview#37
Open
skyc1e wants to merge 1 commit intoPolymarket:mainfrom
Open
docs: fix matchOrders parameter order and types in Overview#37skyc1e wants to merge 1 commit intoPolymarket:mainfrom
skyc1e wants to merge 1 commit intoPolymarket:mainfrom
Conversation
The pseudo-code examples had `makerOrder` and `takerOrder` swapped compared to the actual function signature in CTFExchange.sol, where the first param is `takerOrder` and the second is `makerOrders[]`. Also added missing array brackets on the 4th parameter (`makerFillAmounts` is `uint256[]`) in scenarios 2 and 3. Fixes Polymarket#33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The pseudo-code examples in Overview.md had the first two parameters of
matchOrdersswapped compared to the actual function signature in CTFExchange.sol.CTFExchange.sol signature: