fix(docs): correct matchOrders parameter order in Overview.md#36
Open
Aboudjem wants to merge 1 commit intoPolymarket:mainfrom
Open
fix(docs): correct matchOrders parameter order in Overview.md#36Aboudjem wants to merge 1 commit intoPolymarket:mainfrom
Aboudjem wants to merge 1 commit intoPolymarket:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
matchOrdersparameter order in all three scenario examples (NORMAL, MINT, MERGE)matchOrders(takerOrder, makerOrders, ...)but the docs showedmakerOrderfirstmakerFillAmountsin MINT and MERGE scenarios (25→[25],50→[50])Test plan
CTFExchange.solandTrading.solFixes #33
Note
Low Risk
Low risk documentation-only change that updates example call signatures; no runtime or contract logic is modified.
Overview
Updates
docs/Overview.mdto correct the examplematchOrderscall in all three scenarios so it matches the actual function parameter order (takerOrderfirst,makerOrdersarray second), and fixes themakerFillAmountsexamples to consistently use array syntax (e.g.,[25],[50]).Written by Cursor Bugbot for commit 437b717. This will update automatically on new commits. Configure here.