Skip to content

fix(docs): correct matchOrders parameter order in Overview.md#36

Open
Aboudjem wants to merge 1 commit intoPolymarket:mainfrom
Aboudjem:fix/match-orders-param-order
Open

fix(docs): correct matchOrders parameter order in Overview.md#36
Aboudjem wants to merge 1 commit intoPolymarket:mainfrom
Aboudjem:fix/match-orders-param-order

Conversation

@Aboudjem
Copy link
Copy Markdown

@Aboudjem Aboudjem commented Mar 11, 2026

Summary

  • Fixes the inverted matchOrders parameter order in all three scenario examples (NORMAL, MINT, MERGE)
  • The Solidity signature is matchOrders(takerOrder, makerOrders, ...) but the docs showed makerOrder first
  • Also fixes missing array brackets on makerFillAmounts in MINT and MERGE scenarios (25[25], 50[50])

Test plan

  • Verified against actual Solidity signature in CTFExchange.sol and Trading.sol
  • All three scenarios corrected consistently

Fixes #33


Note

Low Risk
Low risk documentation-only change that updates example call signatures; no runtime or contract logic is modified.

Overview
Updates docs/Overview.md to correct the example matchOrders call in all three scenarios so it matches the actual function parameter order (takerOrder first, makerOrders array second), and fixes the makerFillAmounts examples to consistently use array syntax (e.g., [25], [50]).

Written by Cursor Bugbot for commit 437b717. This will update automatically on new commits. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

matchOrders parameter order in Overview.md examples

1 participant