Skip to content

Conversation

not-a-cowfr
Copy link
Contributor

@not-a-cowfr not-a-cowfr commented Jul 20, 2025

Description

adds context menu to the following:

  • Account quick select
  • Cluster in main menu

adds some base stylings to menu item
adds a menu seperator with a bit of base styling

Related Issue(s)

n/a

How to test

try right clicking everything

Documentation

n/a

@not-a-cowfr not-a-cowfr marked this pull request as draft July 21, 2025 02:09
@not-a-cowfr not-a-cowfr force-pushed the feat/account-select-context-menu branch from 3e6fca9 to b4c7ef4 Compare July 21, 2025 02:23
@not-a-cowfr not-a-cowfr changed the title Add context menu to account quick select menu Context menus :trollface: Jul 21, 2025
@Wyvest
Copy link
Member

Wyvest commented Jul 21, 2025

when you’re done can we get a screenshot of how it works

@not-a-cowfr
Copy link
Contributor Author

i had to remove the link to open the settings when clicking a cluster because it would intervene with editing the name, but i feel like only having right click -> properties isnt good.

this was my first idea, keep the link removed and add a edit button on hover
image

but the other option was adding back the link in the cluster to go to the cluster page and just have it disabled while editing, but the issue is that when clicking the submit button, the link gets reenabled before the click goes through so you end up clicking the link and going to the cluster page

Screen.Recording.2025-07-21.at.1.33.44.AM.mov

idk whats better, i suck at ui

@LynithDev
Copy link
Member

It's nice, but it'd be better if the context menu was relative to the pointer.

Also the rename input box should probably be a modal.

@not-a-cowfr
Copy link
Contributor Author

It's nice, but it'd be better if the context menu was relative to the pointer.

i know, i spent a few minutes working on that but couldnt figure it it, im not great at react. hopefully i can work on this tomorrow

@Wyvest Wyvest changed the base branch from onelauncher/main to oneclient/main September 26, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants