-
Notifications
You must be signed in to change notification settings - Fork 10
Context menus
#342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
not-a-cowfr
wants to merge
16
commits into
Polyfrost:oneclient/main
Choose a base branch
from
not-a-cowfr:feat/account-select-context-menu
base: oneclient/main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Context menus
#342
not-a-cowfr
wants to merge
16
commits into
Polyfrost:oneclient/main
from
not-a-cowfr:feat/account-select-context-menu
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3e6fca9
to
b4c7ef4
Compare

when you’re done can we get a screenshot of how it works |
It's nice, but it'd be better if the context menu was relative to the pointer. Also the rename input box should probably be a modal. |
i know, i spent a few minutes working on that but couldnt figure it it, im not great at react. hopefully i can work on this tomorrow |
…uncher into feat/account-select-context-menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds context menu to the following:
adds some base stylings to menu item
adds a menu seperator with a bit of base styling
Related Issue(s)
n/a
How to test
try right clicking everything
Documentation
n/a