chroma - Milestone 2 Delivery

[preschian]

Milestone Delivery Checklist

• The delivery template has been copied and updated.
• This pull request is being made by the same account as the accepted application.
• I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
• The delivery is according to the delivery guidelines.

Link to the application pull request: PolkadotOpenSourceGrants/apply#40

[ditavia-br]

@preschian thanks for the milestone delivery. There is some improvements that are needed before proceed. Please take a look at the evaluation document for details. Let me know when I can review again.

[preschian]

Hi @ditavia-br, thank you for the evaluation feedback. I have now added an additional chain to e2e-evm, namely Moonbase Alpha (testnet). I also added the UI and e2e tests for the chain selector. You can see the changes here: https://github.com/avalix-labs/chroma/pull/58/changes

On the app level, the logic was changed from ensurePaseoTestnet() to using switchChain() from wagmi: https://wagmi.sh/core/api/actions/switchChain. On the library level, no changes are required, because during chain switching there is only a wallet confirmation, it is sufficient to use wallet.approveTx()

[ditavia-br]

@preschian thanks for the improvements. The multichain part is still need some adjustments. Please see the evaluation document and provide proper answers and fixes. Let me know when I can take a look again.

[preschian]

Hi @ditavia-br, thanks for the feedback. Here are the latest updates:

1. The guide for multi-chain can be found here: https://chroma-docs.up.railway.app/docs/guides/multi-chain
2. I have covered the rejection case when switching multi-chain here: https://github.com/avalix-labs/chroma/blob/e673b64e02ce0e16985df6a6abbe5f5ebc64a2f1/packages/e2e-evm/tests/example.spec.ts#L51-L62

[ditavia-br]

@preschian thanks for the answer. There are some small things that still need to change. Please see the evaluation document for details. Let me know when I can look again.

[preschian]

Hi @ditavia-br, previously I had already updated the E2E section for the rejection case when switching chains, and then updated the docs to match the E2E code. Now the E2E tests and the docs have been added, including how to create helper utilities at the app level.

• https://chroma-docs.up.railway.app/docs/guides/multi-chain#multi-chain-helper-utilities
• https://github.com/avalix-labs/chroma/blob/a174700249b32c3c21cb2508aa8d06f8e4c265aa/packages/e2e-evm/tests/talisman.spec.ts#L49-L54

In the docs I also explained why the helpers are placed at the app level:
https://chroma-docs.up.railway.app/docs/guides/multi-chain#why-app-level-helpers-instead-of-built-in-library-utilities

[ditavia-br]

@preschian I checked again and now the milestone is accepted. Great work!

[preschian]

Thanks @ditavia-br for the review and confirmation. Much appreciated!