Skip to content

Commit

Permalink
Code review changes:
Browse files Browse the repository at this point in the history
- cockpit core version extracted to dependencies.gradle
  • Loading branch information
piwonski committed Jul 9, 2018
1 parent a48ccc2 commit 8cd99a0
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions build.gradle
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/// / Top-level build file where you can add configuration options common to all sub-projects/modules.
apply plugin: 'kotlin'
apply from: 'gradle/dependencies.gradle'

ext {
supportLibraryVersion = '27.1.1'
Expand Down
2 changes: 0 additions & 2 deletions cockpit/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ apply plugin: 'kotlin-android-extensions'
apply from: rootProject.file('gradle/publishing.gradle')

buildscript {
ext.cockpit_core_version = '1.1.1-SNAPSHOT'

dependencies {
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
classpath 'com.android.tools.build:gradle:3.1.3'
Expand Down
3 changes: 3 additions & 0 deletions gradle/dependencies.gradle
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
ext {
cockpit_core_version = '1.1.1-SNAPSHOT'
}
1 change: 0 additions & 1 deletion sample/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ apply plugin: 'kotlin-android-extensions'
apply plugin: 'com.polidea.cockpit'

buildscript {
ext.cockpit_core_version = '1.1.1-SNAPSHOT'
repositories {
jcenter()
mavenCentral()
Expand Down

0 comments on commit 8cd99a0

Please sign in to comment.