Setup a sanitized build for CSP #577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGlustein
requested review from
svatasoiu,
alexddobkin,
ptomecek and
timkpaine
as code owners
AdamGlustein
force-pushed
the
csp-sanitized-build
branch
from
c7faed8 to
02d13af
Compare
Signed-off-by: Adam Glustein <[email protected]>
AdamGlustein
force-pushed
the
csp-sanitized-build
branch
from
02d13af to
3dcc63e
Compare
timkpaine
reviewed
Aug 14, 2025
timkpaine
reviewed
Aug 14, 2025
alexddobkin
reviewed
Aug 14, 2025
Signed-off-by: Adam Glustein <[email protected]>
AdamGlustein
force-pushed
the
csp-sanitized-build
branch
from
fa32500 to
c5bb91e
Compare
Signed-off-by: Adam Glustein <[email protected]>
AdamGlustein
force-pushed
the
csp-sanitized-build
branch
3 times, most recently
from
2bac8fb to
42ef386
Compare
Signed-off-by: Adam Glustein <[email protected]>
AdamGlustein
force-pushed
the
csp-sanitized-build
branch
from
42ef386 to
3f71b23
Compare
…zed-build Signed-off-by: Adam Glustein <[email protected]>
AdamGlustein
force-pushed
the
csp-sanitized-build
branch
2 times, most recently
from
c4d785b to
1e75133
Compare
Signed-off-by: Adam Glustein <[email protected]>
AdamGlustein
force-pushed
the
csp-sanitized-build
branch
from
1e75133 to
2f827de
Compare
AdamGlustein
force-pushed
the
csp-sanitized-build
branch
from
2f827de to
8416044
Compare
svatasoiu
previously approved these changes
Sep 16, 2025
Signed-off-by: Adam Glustein <[email protected]>
AdamGlustein
force-pushed
the
csp-sanitized-build
branch
5 times, most recently
from
ea4d77e to
13decaa
Compare
Signed-off-by: Adam Glustein <[email protected]>
…zed-build Signed-off-by: Adam Glustein <[email protected]>
AdamGlustein
force-pushed
the
csp-sanitized-build
branch
from
13decaa to
b8f5cd4
Compare
|
I could not get the sanitizer libraries properly installed on the GitHub runners so we're just going to have to do the weekly runs in conda. |
AdamGlustein
force-pushed
the
csp-sanitized-build
branch
2 times, most recently
from
6619ceb to
828e881
Compare
robambalu
reviewed
Sep 25, 2025
|
For reference, conda run on GH with Linux (gcc) and MacOS (clang) sanitizers: https://github.com/Point72/csp/actions/runs/18021031665/job/51278154173 |
Signed-off-by: Adam Glustein <[email protected]>
AdamGlustein
force-pushed
the
csp-sanitized-build
branch
from
828e881 to
83fb16e
Compare
robambalu
approved these changes
Sep 25, 2025
timkpaine
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic to build and test CSP with ASan and UBSan support. It also fixes a few issues found when running the tests under the sanitizers.