Do not ignore Alembic migration context prefixes when generating migrations #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When generating the migrations
alembic-postgresql-enum
assumes that both SQLalchemy and Alembic's module prefixes are the default ones.To fix this issue the following changes have been introduced:
I had to disable running the test
TestNewArrayColumnColumnCustomContext
as how they are executed does not allow (at least to the extent of my knowledge) using "nested" modules (e.g.alembic.op
breaks withFAILED sync_enum_values/test_run_array_new_column.py::TestNewArrayColumnColumnCustomContext::test_run - NameError: name 'alembic' is not defined
).Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>
in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>
in the commit messageHave a nice day!