Skip to content

Add tests and support for enum names which are camel case. Fixes: #11… #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Apteryx0
Copy link

@Apteryx0 Apteryx0 commented Apr 17, 2025

Description

Our org recently added alembic-postgresql-enum to our code-base, but we have legacy enums with camel-case names, which caused a very specific error just sql that renames the enum type to <enum>_old. The rename_type function expects arguments to be quoted - this changes ensures that the enum type name is.

Oh, I originally mistakenly edited test_exotic_column_name.py before realising it was the wrong test. I left it in there since I guess it does test CamelCase column names now...? :-)

Fixes: #110

Checklist

This pull request is:

  • A documentation / typographical / small typing error fix
    • Good to go, no issue or tests are needed
  • A short code fix
    • please include the issue number, and create an issue if none exists, which
      must include a complete example of the issue. one line code fixes without an
      issue and demonstration will not be accepted.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests. one line code fixes without tests will not be accepted.
  • A new feature implementation
    • please include the issue number, and create an issue if none exists, which must
      include a complete example of how the feature would look.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests.

Have a nice day!

@AlexandrovRoman AlexandrovRoman self-requested a review May 5, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with enum names that are CamelCase
1 participant