Add tests and support for enum names which are camel case. Fixes: #11… #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our org recently added alembic-postgresql-enum to our code-base, but we have legacy enums with camel-case names, which caused a very specific error just sql that renames the enum type to
<enum>_old
. Therename_type
function expects arguments to be quoted - this changes ensures that the enum type name is.Oh, I originally mistakenly edited
test_exotic_column_name.py
before realising it was the wrong test. I left it in there since I guess it does test CamelCase column names now...? :-)Fixes: #110
Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>
in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>
in the commit messageHave a nice day!