Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed falsy payload case #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

vaukalak
Copy link

there could be some simple payloads like 0, '' or false, that will be skipped in current implementation. for that reason need to check against undefined.

there could be some simple payloads like `0`, `''` or `false`, that will be skipped in current implementation. for that reason need to check against `undefined`.
@sergiodxa
Copy link
Contributor

Hi @vaukalak

I'm the original author of the lib, since @PlatziDev is no longer maintaining this library I moved it back to my own account in https://github.com/sergiodxa/redux-duck.

I also solved this issue passing payload always to the action object, this way the property will be there always and you can decide to ignore it or use it based on what you know will be there.

This is published as the v1.1.0 of redux-duck in npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants