Skip to content

(CodeQL) Sandboxed URL creation to prevent SSRF attacks #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pixeebot-edge wants to merge 1 commit into
base: main
Choose a base branch
from
Open

(CodeQL) Sandboxed URL creation to prevent SSRF attacks #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/src/main/java/org/apache/roller/planet/business/fetcher/RomeFeedFetcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,12 @@ public Subscription fetchSubscription(String feedURL, Date lastModified) throws
throw new IllegalArgumentException("feed url cannot be null");
}

// Validate the feed URL to prevent SSRF attacks. Replace 'http://trusted.com' with your allowed URL prefix or perform a proper whitelist check
final String ALLOWED_PREFIX = "http://trusted.com"; // FIXME: update placeholder with actual authorized URL prefix
if (!feedURL.startsWith(ALLOWED_PREFIX)) {
throw new FetcherException("Unauthorized feed URL: " + feedURL);
}

// fetch the feed
log.debug("Fetching feed: "+feedURL);
SyndFeed feed;
Expand Down
Loading