Skip to content

Hardening suggestions for roller-demo / pixeebot/drip-2025-02-05-codeql-java/ssrf #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pixeebot wants to merge 1 commit into
base: pixeebot/drip-2025-02-05-codeql-java/ssrf
Choose a base branch
from
Open

Hardening suggestions for roller-demo / pixeebot/drip-2025-02-05-codeql-java/ssrf #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/src/main/java/org/apache/roller/weblogger/util/MediacastUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
package org.apache.roller.weblogger.util;

import io.github.pixee.security.HostValidator;
import static io.github.pixee.security.Newlines.stripAll;
import io.github.pixee.security.Urls;
import java.net.HttpURLConnection;
import java.net.MalformedURLException;
Expand Down Expand Up @@ -74,11 +75,11 @@ public static MediacastResource lookupResource(String url)
}

resource = new MediacastResource(url, contentType, length);
LOG.debug("Valid mediacast resource = " + resource.toString());
LOG.debug("Valid mediacast resource = " + stripAll(resource.toString()));

}
} catch (MalformedURLException mfue) {
LOG.debug("Malformed MediaCast url: " + url);
LOG.debug("Malformed MediaCast url: " + stripAll(url));
throw new MediacastException(BAD_URL, "weblogEdit.mediaCastUrlMalformed", mfue);
} catch (Exception e) {
LOG.error("ERROR while checking MediaCast URL: " + url + ": " + e.getMessage());
Expand Down