Skip to content

✨ (Snyk) Fixed finding: "csharp/PT" #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pixee-demo wants to merge 1 commit into
base: v6.0
Choose a base branch
from
+14 −2
Open

✨ (Snyk) Fixed finding: "csharp/PT" #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Raven.Server/Web/Studio/DataDirectoryInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,19 @@ public DataDirectoryInfo(
bool getNodesInfo, int requestTimeoutInMs, Stream responseBodyStream)
{
_serverStore = serverStore;
_path = path;
_path = SanitizePath(path);
_name = name;
_isBackup = isBackup;
_getNodesInfo = getNodesInfo;
_requestTimeoutInMs = requestTimeoutInMs;
_responseBodyStream = responseBodyStream;
}

private string SanitizePath(string path)
{
return Path.GetFileName(path);
}

public async Task UpdateDirectoryResult(string databaseName, string error)
{
var drivesInfo = PlatformDetails.RunningOnPosix ? DriveInfo.GetDrives() : null;
Expand Down
9 changes: 8 additions & 1 deletion src/Raven.Server/Web/Studio/StudioTasksHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
using Sparrow.Json;
using Sparrow.Json.Parsing;
using Voron.Util.Settings;

namespace Raven.Server.Web.Studio
{
public sealed class StudioTasksHandler : ServerRequestHandler
Expand All @@ -27,6 +26,14 @@ public sealed class StudioTasksHandler : ServerRequestHandler
public async Task FullDataDirectory()
{
var path = GetStringQueryString("path", required: false);
if (!string.IsNullOrEmpty(path))
{
path = Path.GetFullPath(path);
if (!path.StartsWith(ServerStore.Configuration.Core.DataDirectory.FullPath))
{
throw new InvalidOperationException("Invalid path");
}
}
var name = GetStringQueryString("name", required: false);
var requestTimeoutInMs = GetIntValueQueryString("requestTimeoutInMs", required: false) ?? 5 * 1000;

Expand Down