Skip to content

✨ (sonar) Fixed 2 findings #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pixee-demo wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −5
Open

✨ (sonar) Fixed 2 findings #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions WebGoat/App_Code/DB/MySqlDbProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ public DataSet GetCatalogData()
{
using (MySqlConnection connection = new MySqlConnection(_connectionString))
{
MySqlDataAdapter da = new MySqlDataAdapter("select * from Products", connection);
MySqlCommand cmd = new MySqlCommand("select * from Products", connection);
MySqlDataAdapter da = new MySqlDataAdapter(cmd);
DataSet ds = new DataSet();

da.Fill(ds);
Expand Down Expand Up @@ -412,12 +413,14 @@ public DataSet GetProductDetails(string productCode)

using (MySqlConnection connection = new MySqlConnection(_connectionString))
{
sql = "select * from Products where productCode = '" + productCode + "'";
da = new MySqlDataAdapter(sql, connection);
MySqlCommand cmd = new MySqlCommand("select * from Products where productCode = @productCode", connection);
cmd.Parameters.AddWithValue("@productCode", productCode);
da = new MySqlDataAdapter(cmd);
da.Fill(ds, "products");

sql = "select * from Comments where productCode = '" + productCode + "'";
da = new MySqlDataAdapter(sql, connection);
cmd = new MySqlCommand("select * from Comments where productCode = @productCode", connection);
cmd.Parameters.AddWithValue("@productCode", productCode);
da = new MySqlDataAdapter(cmd);
da.Fill(ds, "comments");

DataRelation dr = new DataRelation("prod_comments",
Expand Down