Skip to content

✨ (sonar) Fixed finding: "Change this code to not construct SQL queries directly from user-controlled data." #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pixee-demo wants to merge 1 commit into
base: master
Choose a base branch
from
+21 −20
Open

✨ (sonar) Fixed finding: "Change this code to not construct SQL queries directly from user-controlled data." #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 21 additions & 20 deletions WebGoat/App_Code/DB/SqliteDbProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,14 +76,15 @@ public bool IsValidCustomerLogin(string email, string password)
string encoded_password = Encoder.Encode(password);

//check email/password
string sql = "select * from CustomerLogin where email = '" + email + "' and password = '" +
encoded_password + "';";
string sql = "select * from CustomerLogin where email = @Email and password = @Password;";

using (SqliteConnection connection = new SqliteConnection(_connectionString))
{
connection.Open();

SqliteDataAdapter da = new SqliteDataAdapter(sql, connection);
da.SelectCommand.Parameters.AddWithValue("@Email", email);
da.SelectCommand.Parameters.AddWithValue("@Password", encoded_password);

//TODO: User reader instead (for all calls)
DataSet ds = new DataSet();
Expand All @@ -105,23 +106,23 @@ public bool IsValidCustomerLogin(string email, string password)
}

public bool RecreateGoatDb()
{
try
{
log.Info("Running recreate");
string args = string.Format("\"{0}\"", _dbFileName);
string script = Path.Combine(Settings.RootDir, DbConstants.DB_CREATE_SQLITE_SCRIPT);
int retVal1 = Math.Abs(Util.RunProcessWithInput(_clientExec, args, script));
script = Path.Combine(Settings.RootDir, DbConstants.DB_LOAD_SQLITE_SCRIPT);
int retVal2 = Math.Abs(Util.RunProcessWithInput(_clientExec, args, script));
return Math.Abs(retVal1) + Math.Abs(retVal2) == 0;
}
catch (Exception ex)
{
log.Error("Error rebulding DB", ex);
return false;
{
try
{
log.Info("Running recreate");
string args = string.Format("\"{0}\"", _dbFileName);
string script = Path.Combine(Settings.RootDir, DbConstants.DB_CREATE_SQLITE_SCRIPT);
int retVal1 = Math.Abs(Util.RunProcessWithInput(_clientExec, args, script));

script = Path.Combine(Settings.RootDir, DbConstants.DB_LOAD_SQLITE_SCRIPT);
int retVal2 = Math.Abs(Util.RunProcessWithInput(_clientExec, args, script));

return Math.Abs(retVal1) + Math.Abs(retVal2) == 0;
}
catch (Exception ex)
{
log.Error("Error rebulding DB", ex);
return false;
}
}

Expand Down Expand Up @@ -587,4 +588,4 @@ public DataSet GetCustomerEmails(string email)
}

}
}
}