Ensure dependencies are traversed in scriptModuleLoader
#2987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvmkuruc
force-pushed
the
scriptmoduleloader
branch
from
b8a9889 to
689cda0
Compare
|
Filed as internal issue #USD-9388 |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nvmkuruc
force-pushed
the
scriptmoduleloader
branch
from
689cda0 to
3ecf65c
Compare
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nvmkuruc
force-pushed
the
scriptmoduleloader
branch
from
3ecf65c to
00a9db5
Compare
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nvmkuruc
force-pushed
the
scriptmoduleloader
branch
from
00a9db5 to
2144dd0
Compare
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nvmkuruc
force-pushed
the
scriptmoduleloader
branch
from
2144dd0 to
19c5651
Compare
nvmkuruc
force-pushed
the
scriptmoduleloader
branch
from
19c5651 to
c7501a6
Compare
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
_HasTransitiveSuccessoriterates over a predecessor's successors with an unused variablejand then attempts to tag the predecessor to be visited when it should be tagging the successors.This change replaces the
TF_FOR_ALLwith a range based for loop and changes the logic so that successors are now added to the predecessor stack.This also ensures that the initial state of the visit tracking
TfHashSetmatches the initial state of the stack, avoiding unnecessary re-visitation of the initial predecessor.Fixes Issue(s)