Port to Embree 4.x #2266
Open
Port to Embree 4.x #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-8002 |
13 tasks
musicinmybrain
force-pushed
the
embree4
branch
2 times, most recently
from
e7c6f67 to
c8fec13
Compare
Need this so we can drop this patch in nixpkgs :3 |
|
/AzurePipelines run |
|
Pull request contains merge conflicts. |
musicinmybrain
force-pushed
the
embree4
branch
from
c8fec13 to
a07a6b4
Compare
|
Rebased on |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Adjusts CMake scripts and
#includepaths to properly find version 4.x of Embree.Adjusts for renaming of
RTCIntersectContexttoRTCRayQueryContextand modifiedrtcIntersect1/rtcOccludedsignatures.See Embree 4.0.0 changelog and upgrade notes.
Fixes Issue(s)
I am not currently able to easily run the tests.
This PR, applied as a patch to USD 22.05b for the upcoming Fedora 38 and 39 releases, seems to make it compatible with Embree 4.x. At least, the library compiles.