-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meshlab: 2022.02 -> 2023.12 #299049
meshlab: 2022.02 -> 2023.12 #299049
Conversation
3aff545
to
5987fad
Compare
"MAN1DIR=$(man)/share/man//man1" | ||
]; | ||
|
||
makefile = if stdenv.isDarwin then "Makefile.macosx" else "Makefile.linux"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NB: I didn't test on darwin
This branch now include #298963, #298888, and PixarAnimationStudios/OpenUSD#2266, and pymeshlab seems to be working |
Result of 16 packages built:
|
repo = finalAttrs.pname; | ||
rev = "v${finalAttrs.version}"; | ||
hash = "sha256-IOlRdXoUPOJt67g3HqsLchV5aL+JUEks2y1Sy+wpwsg="; | ||
fetchSubmodules = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are not using them, why even download them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, here, I iuse the meshlab submodule, as upstream is basically rebuilding meshlab to get pymeshlab.
I wasn't able to do otherwise yet, so I think this should be fixed upstream first. But I would be glad if anybody find another solution !
Co-authored-by: Sandro <[email protected]>
Result of 8 packages failed to build:
4 packages built:
edit: I need to manually download Xcode.app on this machine |
About testing: on linux, I can import pymeshlab and use, with eg. https://gist.github.com/nim65s/295bc6eda86dc8250e982dac566a96f5#file-lighter-meshes-py to reduce some meshes. I can also open a meshlab gui and use it to load a mesh, but I don't have the icons in the app, and the 3D view is full black. I have the same issue with the package before this PR, so maybe something is wrong with my setup, or meshlab was just broken before. Blender GUI also seems to work fine, but I'm not sure how to specifically test openUSD inside blender. |
Result of 16 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to openusd look fine to me, and I can confirm that opening a usd file in blender works.
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Sandro <[email protected]>
af9eac2
to
fc7d8b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've cleaned up the commit history a bit
Description of changes
This WIP requires #298963, #298888, PixarAnimationStudios/OpenUSD#2266
I'll try to add pymeshlab.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.