-
Notifications
You must be signed in to change notification settings - Fork 15
Add position types #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
On the phone. proto_len for [i32; 3] is 12 not 8. |
@toqueteos: I'm assuming you're referring to |
@fenhl Yup, that's right. Android's GitHub app isn't that great for reviewinh, my bad. I'll clean up comments when I get home. Seems good to merge but I'm worried about fixed point positions and those triplets multiplied by random values (gaussian, 8, ...) |
We can always add |
@fenhl Those are encoding operations. |
ah, good point. Those are the fixed-point number types. We will have to implement all of these manually until integer-parameterized types land. |
Ready to merge. |
I suppose we can add tests later. |
Do not merge yet: this could use some tests.
Adds a
types::pos
module withProtocol
impls for[T; 3] where T: Protocol
, meant to represent 3D coordinates (block positions as well as exact ones). Additionally, aBlockPos
type encodes[i32; 3]
positions as the Position protocol type.