-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Google Sheets - watch drive instead of file #18631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Warning Rate limit exceeded@michelle0927 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 14 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughUpdates package versions and source metadata across Google Sheets components. The HTTP-based sheet source now imports and exposes Drive methods, adds a watchDrive prop and change-token helpers, branches activateHook/renew/ run logic to support drive-watching (including early HTTP 200 responses), and adjusts the HTTP prop shape for custom responses. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User / External Event
participant S as HTTP-based Sheet Source
participant D as drive.mjs (methods)
participant GS as googleSheets
participant GAPI as Google Drive/Sheets API
U->>S: activateHook(channelID)
alt watchDrive = true
S->>D: getDriveId(watchedDrive)
D->>GAPI: Resolve Drive ID
GAPI-->>D: Drive ID
S->>GS: activateHook(channelID, driveId)
else watchDrive = false
S->>GS: activateFileHook(channelID, sheetId)
end
GS->>GAPI: Create/verify webhook
GAPI-->>GS: Hook activated
GS-->>S: Activation result
sequenceDiagram
autonumber
participant Timer as Timer
participant S as HTTP-based Sheet Source
participant D as drive.mjs
participant GS as googleSheets
participant GAPI as Google Drive/Sheets API
Timer->>S: run(timer event)
alt watchDrive = true
S->>D: renewDriveSubscription()
D->>GAPI: Renew drive subscription / list changes
GAPI-->>D: Changes, new token
D-->>S: Updated channel / token
else
S->>GS: renewSubscription()
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @michelle0927, LGTM! Ready for QA!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (4)
components/google_sheets/sources/common/http-based/base.mjs
(1 hunks)components/google_sheets/sources/common/http-based/drive.mjs
(1 hunks)components/google_sheets/sources/common/http-based/sheet.mjs
(4 hunks)components/google_sheets/sources/new-row-added-polling/new-row-added-polling.mjs
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- components/google_sheets/sources/new-row-added-polling/new-row-added-polling.mjs
🧰 Additional context used
🧬 Code graph analysis (1)
components/google_sheets/sources/common/http-based/sheet.mjs (2)
components/google_sheets/sources/common/http-based/base.mjs (4)
channelID
(78-78)channelID
(80-84)channelID
(101-101)subscription
(102-102)components/google_sheets/sources/common/http-based/drive.mjs (8)
channelID
(39-47)channelID
(79-79)channelID
(104-104)pageToken
(84-84)newStartPageToken
(57-60)subscription
(78-78)subscription
(103-103)subscription
(106-117)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: Lint Code Base
Hi everyone, all test cases are passed! Ready for release! Test report |
/approve |
Updates Google Sheets sources to watch the drive instead of the selected file.
Summary by CodeRabbit
Chores
New Features
Refactor