build: setup CI/CD for package publishing #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename package with pipedream org scope
fixes: ``` getCacheEntry failed: Cache service responded with 503 ```
There was a problem hiding this comment.
Pull Request Overview
This PR configures CI/CD for npm publishing and scopes the ESLint plugin package under the Pipedream org.
- Renames the package to
@pipedream/eslint-plugin-pipedream - Updates install instructions in README
- Upgrades workflow actions and adds a publish-to-npm workflow
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Renamed package to scoped name |
| README.md | Updated install command to use the new package scope |
| .github/workflows/pull-request-checks.yaml | Bumped actions/checkout and setup-node to v4 |
| .github/workflows/publish-package.yaml | Added workflow to publish package on push to master branch |
Comments suppressed due to low confidence (4)
.github/workflows/publish-package.yaml:5
- The workflow is triggered on push to 'master', but the default branch is 'main'. Update this to 'main' so the publish step actually runs.
- master
.github/workflows/publish-package.yaml:22
- The conditional checks for 'refs/heads/master' but the repo uses 'main' as the default branch. Change this to 'refs/heads/main'.
if: github.ref == 'refs/heads/master'
.github/workflows/publish-package.yaml:16
- [nitpick] Node.js 14 is no longer maintained; consider upgrading to a current LTS (e.g., 18.x or 20.x) to benefit from security fixes and newer language features.
node-version: '14.x'
.github/workflows/pull-request-checks.yaml:18
- [nitpick] This workflow also pins Node.js to 14.x, which is EOL. Upgrading to a supported LTS version (18.x or newer) will help ensure compatibility and security.
node-version: 14.x
jverce
reviewed
Jun 25, 2025
| - run: npm ci | ||
| - run: npm test | ||
| - name: npm publish | ||
| if: github.ref == 'refs/heads/master' |
There was a problem hiding this comment.
This might be redundant since we're running this workflow only when there's a push to master.
jverce
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mastereslint-plugin-pipedreamto@pipedream/eslint-plugin-pipedreamto publish in org scopeactions/checkoutandactions/setup-nodeto v4 in PR check WF to fix:getCacheEntry failed: Cache service responded with 503For reference, the ESLint docs suggest naming scoped packages
@<scope>/eslint-plugin-<plugin-name>.