Skip to content

Conversation

js07
Copy link
Contributor

@js07 js07 commented Jun 23, 2025

  • Stop requiring label and description properties for 'dir' props
  • Refactor label/description exemption logic for props
  • Add test cases for 'dir' type props in component tests
  • Update actions/checkout and actions/setup-node to v4 in PR check WF to fix: getCacheEntry failed: Cache service responded with 503

Addresses this eslint warning:
image

js07 added 3 commits June 23, 2025 15:19
refactor: rename and enhance label/description exemption logic for props

test: add cases for 'dir' type props in component tests
fixes:
```
getCacheEntry failed: Cache service responded with 503
```
@js07 js07 marked this pull request as ready for review June 24, 2025 18:17
@jverce jverce requested a review from Copilot June 24, 2025 22:49
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a fix to exempt "dir" props from requiring label and description properties by refactoring the exemption logic and updating tests accordingly. Key changes include:

  • Refactoring the exemption logic in index.js by replacing the default interface check with a new isExemptFromLabelDescriptionRequirement function.
  • Updating component tests in tests/rules.test.js and tests/components.js to include "dir" prop test cases.
  • Bumping dependency versions in the GitHub workflow and package.json for reliability.

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/rules.test.js Updated to support multiple valid components with the new validComponents field
tests/components.js Added test components for "dir" props
package.json Version bumped from 0.2.4 to 0.2.5
index.js Updated exemption logic for label/description based on prop type ("dir")
.github/workflows/pull-request-checks.yaml Updated checkout and setup-node actions versions
Comments suppressed due to low confidence (1)

index.js:24

  • [nitpick] Consider adding inline documentation to explain the exemption logic, specifically clarifying why dir props are exempt alongside default interface props, to aid future maintainers.
function isExemptFromLabelDescriptionRequirement(propertyName, properties) {

Resolve merge conflicts in package.json and package-lock.json
@js07 js07 merged commit 26bd0eb into PipedreamHQ:master Jun 25, 2025
1 check passed
@js07 js07 deleted the fix/props-label-description-required-dir-prop branch June 25, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants