Add location groups and fix some inconsistencies in location names#4
Open
wolicodes wants to merge 1 commit intoPinkSwitch:meleefrom
Open
Add location groups and fix some inconsistencies in location names#4wolicodes wants to merge 1 commit intoPinkSwitch:meleefrom
wolicodes wants to merge 1 commit intoPinkSwitch:meleefrom
Conversation
Author
|
The enum addition is debatable, I can remove it if needed |
Owner
|
I do not like the use of enums for locations, it just adds a layer of complexity that I just don’t think needs to be there when they are clear enough as strings (I don’t intend on changing them much if at all) |
Author
|
Ok I changed it back, I also squashed everything to one commit to make the merge cleaner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Instead of having plain strings for location names duplicated in multiple places, it now uses a reference enum.
I also used this new enum to build a list of location groups.
The list is:
1P Character Trophies (all 1P mode character unlock trophies + all characters for mode trophies)
Annoying Multi-Man
Any 1P Trophies (all "Any 1P" RNG trophies)
Base Trophy Pool
Bonuses
Hard Bonuses
Extreme Bonuses
Event Matches
Hard Modes Clear
Home-Run Contest
Long Target Test
Lottery
Melee (the VS locations)
Multi-Man Melee
RNG Trophies (lottery + base trophy pool + any 1p combined)
Rare Pokemon (the 2 bonuses + the 2 locations for seeing Mew and Celebi)
Target Test
Training Mode
Unlock Matches
How was this tested?
I generated a seed with it and it didn't explode. I also hosted a room and verified that the new location groups were present with
/location_groupson a text client.If this makes graphical changes, please attach screenshots.
N/A