Skip to content

Add location groups and fix some inconsistencies in location names#4

Open
wolicodes wants to merge 1 commit intoPinkSwitch:meleefrom
wolicodes:melee
Open

Add location groups and fix some inconsistencies in location names#4
wolicodes wants to merge 1 commit intoPinkSwitch:meleefrom
wolicodes:melee

Conversation

@wolicodes
Copy link
Copy Markdown

@wolicodes wolicodes commented Apr 2, 2026

What is this fixing or adding?

Instead of having plain strings for location names duplicated in multiple places, it now uses a reference enum.
I also used this new enum to build a list of location groups.

The list is:

1P Character Trophies (all 1P mode character unlock trophies + all characters for mode trophies)
Annoying Multi-Man
Any 1P Trophies (all "Any 1P" RNG trophies)
Base Trophy Pool
Bonuses
Hard Bonuses
Extreme Bonuses
Event Matches
Hard Modes Clear
Home-Run Contest
Long Target Test
Lottery
Melee (the VS locations)
Multi-Man Melee
RNG Trophies (lottery + base trophy pool + any 1p combined)
Rare Pokemon (the 2 bonuses + the 2 locations for seeing Mew and Celebi)
Target Test
Training Mode
Unlock Matches

How was this tested?

I generated a seed with it and it didn't explode. I also hosted a room and verified that the new location groups were present with /location_groups on a text client.

If this makes graphical changes, please attach screenshots.

N/A

@wolicodes
Copy link
Copy Markdown
Author

The enum addition is debatable, I can remove it if needed

@PinkSwitch
Copy link
Copy Markdown
Owner

I do not like the use of enums for locations, it just adds a layer of complexity that I just don’t think needs to be there when they are clear enough as strings (I don’t intend on changing them much if at all)

@wolicodes
Copy link
Copy Markdown
Author

wolicodes commented Apr 3, 2026

Ok I changed it back, I also squashed everything to one commit to make the merge cleaner.
Also, there was a couple of inconsistencies between LocationData and the static list, so I fixed those

@wolicodes wolicodes changed the title Use an enum for consistent location names, and add location groups Add location groups and fix some inconsistencies in location names Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants