Skip to content

Docs/open api 문서 핫픽스 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GoGradually merged 7 commits into from
Jan 23, 2026
Merged

Docs/open api 문서 핫픽스 #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fd2678e
docs: OpenAPI 버전 v2로 업데이트
GoGradually Jan 23, 2026
73d66c8
fix: offsetId 정규화 로직 추가 및 유효성 검사 개선
GoGradually Jan 23, 2026
0c68ac1
fix: TaskControllerAdvice에서 V2 컨트롤러로 변경
GoGradually Jan 23, 2026
8c0afcf
refactor: ScheduleControllerAdvice 및 TaskControllerAdvice 패키지 구조 변경
GoGradually Jan 23, 2026
f421395
fix: ScheduleControllerAdvice 및 TaskControllerAdvice에서 V1 컨트롤러 추가
GoGradually Jan 23, 2026
f536ca3
Revert "fix: offsetId 정규화 로직 추가 및 유효성 검사 개선"
GoGradually Jan 23, 2026
b347386
fix: 잘못된 오프셋 대문자 Z로 정규화
GoGradually Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/003데드라인을 날짜 기준으로 변경/temporal-constraint-deadline-migration.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,9 @@ ALTER TABLE task
-- - If needed, repopulate deadline_time from deadline_date using stored offset (time fixed at 00:00:00):
-- UPDATE task SET deadline_time = CONVERT_TZ(CONCAT(deadline_date, ' 00:00:00'), '+00:00', deadline_offset_id);
-- - Restore NOT NULL/column definitions accordingly.


--- 잘못된 오프셋 대문자 Z로 정규화
UPDATE task
SET deadline_offset_id = 'Z'
WHERE deadline_offset_id IN ('z:', 'z', 'Z:', 'Z0', 'z0', 'utc', 'UT', 'GMT', 'UTC+0', 'UTC+00:00', 'UTC+0000');
2 changes: 1 addition & 1 deletion src/main/java/me/gg/pinit/pinittask/infrastructure/config/OpenApiConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
@OpenAPIDefinition(
info = @Info(
title = "Pinit Task API",
version = "v1",
version = "v2",
description = "일정 관리와 의존 관계 기능을 제공하는 API",
Comment on lines 12 to 14
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(1) 문제점: PR 설명에 포함된 "offset 문자열 정규화 추가"에 해당하는 변경이 현재 diff(ControllerAdvice 범위 조정, OpenAPI Info.version 변경)에서는 확인되지 않습니다.
(2) 영향: 리뷰어/릴리즈 노트 관점에서 실제 반영된 변경과 PR 설명이 불일치해, 누락된 기능이 배포되었다고 오해하거나 필요한 변경이 빠진 채로 머지될 수 있습니다.
(3) 수정 제안: (a) offset 정규화 변경이 다른 커밋/파일에 있다면 이 PR에 포함되도록 올려주시거나, (b) 이번 PR 범위가 문서 버전 표기 변경이라면 PR 설명 체크리스트/내용에서 해당 항목을 제거 또는 별도 PR로 분리해주세요.

Copilot uses AI. Check for mistakes.
contact = @Contact(name = "Pinit Team", email = "[email protected]")
),
Expand Down
7 changes: 5 additions & 2 deletions ...s/exception/ScheduleControllerAdvice.java → ...es/schedule/ScheduleControllerAdvice.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package me.gg.pinit.pinittask.interfaces.exception;
package me.gg.pinit.pinittask.interfaces.schedule;

import lombok.extern.slf4j.Slf4j;
import me.gg.pinit.pinittask.domain.dependency.exception.ScheduleAlreadyRemovedException;
Expand All @@ -8,6 +8,7 @@
import me.gg.pinit.pinittask.domain.member.exception.ObjectiveNotNullException;
import me.gg.pinit.pinittask.domain.member.exception.ObjectiveNotPositiveException;
import me.gg.pinit.pinittask.domain.schedule.exception.*;
import me.gg.pinit.pinittask.interfaces.exception.ErrorResponse;
import org.springframework.http.HttpStatus;
import org.springframework.http.ResponseEntity;
import org.springframework.validation.BindingResult;
Expand All @@ -20,7 +21,9 @@


@Slf4j
@RestControllerAdvice
@RestControllerAdvice(assignableTypes = {
ScheduleControllerV2.class, ScheduleControllerV1.class
})
public class ScheduleControllerAdvice {
@ExceptionHandler({
IllegalTitleException.class,
Expand Down
9 changes: 6 additions & 3 deletions ...faces/exception/TaskControllerAdvice.java → ...interfaces/task/TaskControllerAdvice.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package me.gg.pinit.pinittask.interfaces.exception;
package me.gg.pinit.pinittask.interfaces.task;

import lombok.extern.slf4j.Slf4j;
import me.gg.pinit.pinittask.domain.task.exception.TaskNotFoundException;
import me.gg.pinit.pinittask.interfaces.task.TaskControllerV1;
import me.gg.pinit.pinittask.interfaces.exception.ErrorResponse;
import org.springframework.http.HttpStatus;
import org.springframework.http.ResponseEntity;
import org.springframework.validation.BindingResult;
Expand All @@ -14,7 +14,10 @@
import org.springframework.web.context.request.WebRequest;

@Slf4j
@RestControllerAdvice(assignableTypes = TaskControllerV1.class)
@RestControllerAdvice(assignableTypes = {
TaskControllerV2.class,
TaskControllerV1.class
})
public class TaskControllerAdvice {

@ExceptionHandler(TaskNotFoundException.class)
Expand Down