Feat/레거시 id 제거#16
Merged
GoGradually merged 2 commits intomasterfrom Jan 18, 2026
Hidden character warning
The head ref may contain hidden characters: "feat/\ub808\uac70\uc2dc-id-\uc81c\uac70"
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
이 PR은 PushSubscription과 UpcomingScheduleNotification 엔티티에서 레거시 Long 타입 ID를 제거하고 UUID 기반 publicId만을 사용하도록 리팩토링합니다.
Changes:
PushSubscription및UpcomingScheduleNotification도메인 모델에서legacyId필드 및 관련 생성자 제거- 엔티티 클래스에서 Long 타입
id필드 제거,publicId를 단일 기본 키로 사용 - Repository 어댑터의 매핑 로직에서 레거시 ID 참조 제거
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
PushSubscription.java |
도메인 모델에서 legacyId 필드 및 레거시 생성자 제거 |
PushSubscriptionEntity.java |
Long 타입 id 필드 제거, publicId만 유지 |
PushSubscriptionRepositoryAdapter.java |
toDomain() 및 toEntity() 메서드에서 레거시 ID 매핑 제거 |
UpcomingScheduleNotification.java |
도메인 모델에서 legacyId 필드 및 레거시 생성자 제거 |
UpcomingScheduleNotificationEntity.java |
Long 타입 id 필드 제거, publicId만 유지 |
UpcomingScheduleNotificationRepositoryAdapter.java |
toDomain() 및 toEntity() 메서드에서 레거시 ID 매핑 제거 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경된 점