Fix/cors 설정 수정#10
Merged
GoGradually merged 1 commit intomasterfrom Dec 31, 2025
Hidden character warning
The head ref may contain hidden characters: "fix/cors-\uc124\uc815-\uc81c\uac70"
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
이 PR은 게이트웨이 레벨에서 CORS 처리를 통합함에 따라 애플리케이션 레벨의 중복된 CORS 설정을 제거합니다.
- CORS 관련 설정 파일 및 속성 클래스 제거
- SecurityConfig에서 CORS 설정 빈 및 관련 import 문 삭제
- application.yml에서 CORS 설정 제거
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/resources/application.yml | CORS 관련 설정 속성(allowed-origins, allowed-methods 등) 제거 |
| src/main/java/me/pinitnotification/infrastructure/authenticate/config/SecurityConfig.java | CORS 설정 빈 메서드 및 관련 import 문 삭제 |
| src/main/java/me/pinitnotification/infrastructure/authenticate/config/CorsProperties.java | CORS 속성을 관리하던 설정 클래스 파일 완전 삭제 |
중요 참고사항: 코드 리뷰 중 SecurityConfig.java의 line 31에서 .cors(Customizer.withDefaults())를 사용하고 있는데, 이 PR에서 corsConfigurationSource 빈을 제거하고 있습니다. 게이트웨이에서 CORS를 완전히 처리한다면 해당 라인을 .cors(AbstractHttpConfigurer::disable)로 변경하여 Spring Security의 CORS 처리를 비활성화하는 것을 권장드립니다. 이 라인은 diff 영역 밖에 있어 공식 코멘트를 남길 수 없었으나, 배포 전 확인이 필요한 중요한 사항입니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경된 점