Skip to content

[SYMPP-2DFF] Certify rotating ownership with Windows Job clients - #626

Merged
Pimpmuckl merged 3 commits into
integration/mcp-first-caller-lifecyclefrom
test/sympp-on-demand-03-job-certification
Aug 18, 2026
Merged

[SYMPP-2DFF] Certify rotating ownership with Windows Job clients#626
Pimpmuckl merged 3 commits into
integration/mcp-first-caller-lifecyclefrom
test/sympp-on-demand-03-job-certification

Conversation

@Pimpmuckl

@Pimpmuckl Pimpmuckl commented Aug 18, 2026

Copy link
Copy Markdown
Owner

Context

Native upstream Codex uses non-breakaway Windows Jobs. We need deterministic proof that shared backend ownership rotates across independent clients and stops after the last client.

TL;DR

Certify the shared MCP lifecycle with 32 independent Windows Job clients.

Summary

  • Add a native Job helper and isolated runner to the canonical launcher suite.
  • Prove singleton start, three owner rotations, recovery, mutation safety, and final cleanup.
  • Lower only heavyweight validation parents; live and global process priority stays unchanged.

Alternatives

  • Reuse the existing shipped-command fixture instead of maintaining a second lifecycle model.

Test Plan

  • make -C elixir all — local run hit one unrelated retention-order assertion; GitHub make-all passed.
  • make -C elixir ci-full when release/full validation is required — not required for this test-only package.
  • 32 independent Windows Job certification passed on the merged recovery fix.
  • Performance gate passed on isolated non-default ports.
  • Local launcher matrix hit known PowerShell fallback final-detach lock contention.
  • Review Suite fast completed clean on exact head bff096b1 (rvw_3202ed7c).
  • All GitHub CI checks passed, including all fast and slow test shards.

Pimpmuckl and others added 3 commits August 18, 2026 05:31
Summary:
- add an isolated 32-client non-breakaway Job Object certification
- verify owner rotation, recovery, STDIO continuity, and final cleanup
- lower only heavyweight validation parents before child processes start

Rationale:
- model native upstream Codex Job semantics through the shipped command
- keep lifecycle certification in the existing canonical launcher fixture

Tests:
- Windows Job certification passed
- performance gate passed
- launcher matrix hit known fallback final-detach lock contention
- make -C elixir all passed setup/build/static; one unrelated order test failed

Co-authored-by: Codex <codex@openai.com>
Summary:
- count every remaining adapter lease file during final Job cleanup

Rationale:
- dead adapter PIDs must not hide stale lease records from certification

Tests:
- node --check cold-start-singleton-smoke.js
- git diff --check

Co-authored-by: Codex <codex@openai.com>
Summary:
- let the last bridge process EOF and remove its lease before Job disposal

Rationale:
- forced final termination cannot prove zero persisted adapter lease files

Tests:
- node --check cold-start-singleton-smoke.js
- git diff --check

Co-authored-by: Codex <codex@openai.com>
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9adae7bb-d087-4acb-8f97-fc88f72dadaa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@Pimpmuckl
Pimpmuckl merged commit 756cdeb into integration/mcp-first-caller-lifecycle Aug 18, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant