[SYMPP-2DFF] Certify rotating ownership with Windows Job clients - #626
Merged
Pimpmuckl merged 3 commits intoAug 18, 2026
Conversation
Summary: - add an isolated 32-client non-breakaway Job Object certification - verify owner rotation, recovery, STDIO continuity, and final cleanup - lower only heavyweight validation parents before child processes start Rationale: - model native upstream Codex Job semantics through the shipped command - keep lifecycle certification in the existing canonical launcher fixture Tests: - Windows Job certification passed - performance gate passed - launcher matrix hit known fallback final-detach lock contention - make -C elixir all passed setup/build/static; one unrelated order test failed Co-authored-by: Codex <codex@openai.com>
Summary: - count every remaining adapter lease file during final Job cleanup Rationale: - dead adapter PIDs must not hide stale lease records from certification Tests: - node --check cold-start-singleton-smoke.js - git diff --check Co-authored-by: Codex <codex@openai.com>
Summary: - let the last bridge process EOF and remove its lease before Job disposal Rationale: - forced final termination cannot prove zero persisted adapter lease files Tests: - node --check cold-start-singleton-smoke.js - git diff --check Co-authored-by: Codex <codex@openai.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Pimpmuckl
merged commit Aug 18, 2026
756cdeb
into
integration/mcp-first-caller-lifecycle
20 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Native upstream Codex uses non-breakaway Windows Jobs. We need deterministic proof that shared backend ownership rotates across independent clients and stops after the last client.
TL;DR
Certify the shared MCP lifecycle with 32 independent Windows Job clients.
Summary
Alternatives
Test Plan
make -C elixir all— local run hit one unrelated retention-order assertion; GitHubmake-allpassed.make -C elixir ci-fullwhen release/full validation is required — not required for this test-only package.bff096b1(rvw_3202ed7c).