[SYMPP-MCP] Keep tool catalogs stable across assignment claims - #622
Closed
Pimpmuckl wants to merge 2 commits into
Closed
[SYMPP-MCP] Keep tool catalogs stable across assignment claims#622Pimpmuckl wants to merge 2 commits into
Pimpmuckl wants to merge 2 commits into
Conversation
Summary: - advertise a configured role catalog for the full MCP session lifetime - keep claim authorization role-scoped without changing tool discovery - remove claim and release re-list guidance and add HTTP regressions Rationale: - MCP clients discover tools once and cannot rely on post-claim re-listing - stable catalogs separate discovery from live authorization and scope Tests: - mix test test/symphony_elixir/symphony_plus_plus/mcp/claim_session_transport_07_test.exs test/symphony_elixir/symphony_plus_plus/mcp_http_transport_minimal_test.exs test/symphony_elixir/symphony_plus_plus/mcp_http_endpoint_test.exs Co-authored-by: Codex <codex@openai.com>
|
Caution Review failedAn error occurred during the review process. Please try again later. Comment |
Summary: - keep branch optional in the stable attach_branch tool schema - fingerprint configured startup catalogs in the published MCP contract Rationale: - schema-driven clients must keep using assignment branch inference - artifact selection must reject backends with incompatible startup catalogs Tests: - mix test test/symphony_elixir/symphony_plus_plus/mcp/claim_session_transport_07_test.exs test/symphony_elixir/symphony_plus_plus/mcp/connection_bootstrap_02_test.exs test/symphony_elixir/symphony_plus_plus/mcp/worker_tools_01_test.exs Co-authored-by: Codex <codex@openai.com>
Owner
Author
|
[codex] GitHub's merge API returned repeated 503 errors. The reviewed PR was applied as the authorized equivalent squash commit on main: 472da01. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
MCP clients may list tools only once after initialize. The current server changes its catalog after assignment claims, so clients cannot call newly exposed role tools without a non-standard re-list.
TL;DR
Keep each configured MCP role catalog stable while claims change only authorization and scope.
Summary
Alternatives
Test Plan
make -C elixir allmake -C elixir ci-fullwhen release/full validation is requiredorigin/main: clean and conforming