Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new environment attribute for screenshots #14

Merged

Conversation

ingokloecker
Copy link
Contributor

appstream now officially supports an environment attribute for screenshots.

See ximion/appstream#530

@PhuNH
Copy link
Owner

PhuNH commented Oct 3, 2023

Is it okay for me to squash the commits?

... and remove support for custom x-kde-os attribute for screenshots

appstream now officially supports an environment attribute for screenshots.
@ingokloecker ingokloecker force-pushed the work/screenshots-with-environment-attribute branch from 4202d58 to 5a5926b Compare October 4, 2023 11:53
@ingokloecker
Copy link
Contributor Author

ingokloecker commented Oct 4, 2023

I have squashed the commits. Makes the diff look much nicer.

@PhuNH PhuNH merged commit 1697240 into PhuNH:main Oct 4, 2023
@PhuNH
Copy link
Owner

PhuNH commented Oct 4, 2023

Thank you

@ingokloecker ingokloecker deleted the work/screenshots-with-environment-attribute branch October 4, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants