Skip to content

Validate MJSON configuration files and inheritance #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thibaultzanini wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −14
Open

Validate MJSON configuration files and inheritance #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2317e9e
Fix MJSON configuration validation issues
claude Jan 8, 2026
0d8e8c6
Add orphaned properties to propertyDescriptors array
claude Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions data/model/device/device.mjson
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@
{"@": "nodeDeviceConnections"},
{"@": "possibleHostDeviceConnections"},
{"@": "hostDeviceConnections"},
{"@": "deviceHostConnections"},

{"@": "tools"},
{"@": "toolForDevices"},
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing LGTM


{"@": "ipAddress"},
{"@": "port"},
Expand Down Expand Up @@ -255,17 +259,6 @@
}
},

"toolCompatibilityDeviceList": {
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate LGTM

"prototype": "mod/core/meta/property-descriptor",
"values": {
"name": "toolCompatibilityDeviceList",
"cardinality": -1,
"inversePropertyName": "compatibleTools",
"valueDescriptor": {"@": "root"},
"description": "The list of devices that can use this device as a tools"
}
},

"tools": {
"prototype": "mod/core/meta/property-descriptor",
"values": {
Expand All @@ -288,7 +281,6 @@
}
},


"ipAddress": {
"prototype": "mod/core/meta/property-descriptor",
"values": {
Expand Down
4 changes: 2 additions & 2 deletions data/model/device/printing-device.mjson
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"ImagingDeviceDescriptor": {
"object": "./imaging-device.mjson"
},
"ProntDocumentDescriptor": {
"PrintDocumentDescriptor": {
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

"object": "./print-document.mjson"
},

Expand All @@ -33,7 +33,7 @@
"name": "activePrintDocument",
"cardinality": 1,
"valueType": "object",
"valueDescriptor": {"@": "ProntDocumentDescriptor"},
"valueDescriptor": {"@": "PrintDocumentDescriptor"},
"description": "The current document to be printed"
}
}
Expand Down