Validate MJSON configuration files and inheritance #66
+4
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- product.mjson: Remove duplicate 'tags' property definition - collection-rule.mjson: Fix property name mismatch (productProperty -> column) - order-transaction.mjson: Add missing 'kind' property to propertyDescriptors - collection.mjson: Add missing 'type' property to propertyDescriptors All changes ensure proper MJSON structure with correct property descriptor references and inheritance logic.
thibaultzanini
commented
Jan 8, 2026
| "values": { | ||
| "name": "productProperty", | ||
| "name": "column", | ||
| "valueType": "string" |
Contributor
Author
There was a problem hiding this comment.
Not sure about this one
| {"@": "descriptionHtml"}, | ||
| {"@": "image"}, | ||
| {"@": "ruleSet"}, | ||
| {"@": "type"}, |
| {"@": "amount"}, | ||
| {"@": "paymentGateway"} | ||
| {"@": "paymentGateway"}, | ||
| {"@": "kind"} |
| "values": { | ||
| "name": "tags", | ||
| "valueType": "array" | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Probably good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes ensure proper MJSON structure with correct property descriptor references and inheritance logic.