[Review Only] Trajectory base class refactor#1886
Closed
CrimRecya wants to merge 194 commits intoPhobos-developers:developfrom
Closed
[Review Only] Trajectory base class refactor#1886CrimRecya wants to merge 194 commits intoPhobos-developers:developfrom
CrimRecya wants to merge 194 commits intoPhobos-developers:developfrom
Conversation
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
secsome
reviewed
Nov 11, 2025
| DEFINE_HOOK(0x6FC339, TechnoClass_CanFire, 0x6) | ||
| { | ||
| enum { CannotFire = 0x6FCB7E }; | ||
| enum { CannotFire = 0x6FCB7E, TemporarilyCannotFire = 0x6FCD0E }; |
Member
There was a problem hiding this comment.
Did I missing something? where does the TemporarilyCannotFire being used?
Contributor
Author
There was a problem hiding this comment.
Sorry for not organizing it cleanly enough. It was used here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #1582 . For review only.