Allow using <Player @ X> as trigger owner in skirmish/MP#1853
Allow using <Player @ X> as trigger owner in skirmish/MP#1853Starkku wants to merge 1 commit intoPhobos-developers:developfrom
Conversation
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
c51b21b to
5869392
Compare
|
Is this a duplicate of 746? |
5869392 to
5eb21cb
Compare
TaranDahl
left a comment
There was a problem hiding this comment.
I think WW must got shit in their mind to come up with the design of setting the trigger owner as HouseTypeClass instead of HouseClass.
Is there any way to solve these problems at the root?
|
Shoving HouseClass pointer in what game expects to be HouseTypeClass and fixing the use cases on game's side I suppose. Problem remains any other extensions etc. that might not be aware of this change so I do not consider this approach safe. Other option which isn't really fixing the 'root cause' is using extension class instead of a map but it is basically just a different way of doing what has been done here. |
|
Map editors/files also treat the field for trigger types as HouseTypeClass ID. Changing this would brick a lot of map file/editor compatibility. Not sure if that's worth the ability to allow matching triggers to specific HouseClass instances, given that <Player @ X> covers skirmish/MP already and singleplayer maps generally speaking have one HouseClass per HouseTypeClass to begin with. |
|
I'm just asking randomly. It's not something to be solved here. |
|
Yeah I am just explaining (or trying to) why the current approach (or alternatively the extension class one but that just depends on preference I suppose) is the sane one for now atleast. |
5eb21cb to
79ba26d
Compare
79ba26d to
8610421
Compare
Skirmish / multiplayer maps can now use <Player @ X> as trigger owner. If the player is not present in game, the trigger is destroyed and never sprung.