Skip to content

Allow using <Player @ X> as trigger owner in skirmish/MP#1853

Open
Starkku wants to merge 1 commit intoPhobos-developers:developfrom
Starkku:feature/trigger-owner-playeratx
Open

Allow using <Player @ X> as trigger owner in skirmish/MP#1853
Starkku wants to merge 1 commit intoPhobos-developers:developfrom
Starkku:feature/trigger-owner-playeratx

Conversation

@Starkku
Copy link
Copy Markdown
Contributor

@Starkku Starkku commented Sep 11, 2025

Skirmish / multiplayer maps can now use <Player @ X> as trigger owner. If the player is not present in game, the trigger is destroyed and never sprung.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 11, 2025

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@TaranDahl
Copy link
Copy Markdown
Contributor

Is this a duplicate of 746?

@TaranDahl TaranDahl added ⚙️T1 T1 maintainer review is sufficient Needs discussion ❓Unhardcoding / Customization Make something more tweakable labels Nov 27, 2025
@Starkku Starkku force-pushed the feature/trigger-owner-playeratx branch from 5869392 to 5eb21cb Compare December 12, 2025 10:58
Copy link
Copy Markdown
Contributor

@TaranDahl TaranDahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think WW must got shit in their mind to come up with the design of setting the trigger owner as HouseTypeClass instead of HouseClass.
Is there any way to solve these problems at the root?

@Starkku
Copy link
Copy Markdown
Contributor Author

Starkku commented Jan 15, 2026

Shoving HouseClass pointer in what game expects to be HouseTypeClass and fixing the use cases on game's side I suppose. Problem remains any other extensions etc. that might not be aware of this change so I do not consider this approach safe. Other option which isn't really fixing the 'root cause' is using extension class instead of a map but it is basically just a different way of doing what has been done here.

@Starkku
Copy link
Copy Markdown
Contributor Author

Starkku commented Jan 15, 2026

Map editors/files also treat the field for trigger types as HouseTypeClass ID. Changing this would brick a lot of map file/editor compatibility. Not sure if that's worth the ability to allow matching triggers to specific HouseClass instances, given that <Player @ X> covers skirmish/MP already and singleplayer maps generally speaking have one HouseClass per HouseTypeClass to begin with.

@TaranDahl
Copy link
Copy Markdown
Contributor

I'm just asking randomly. It's not something to be solved here.

@Starkku
Copy link
Copy Markdown
Contributor Author

Starkku commented Jan 15, 2026

Yeah I am just explaining (or trying to) why the current approach (or alternatively the extension class one but that just depends on preference I suppose) is the sane one for now atleast.

@Starkku Starkku force-pushed the feature/trigger-owner-playeratx branch from 5eb21cb to 79ba26d Compare January 18, 2026 15:26
GreyVacuum added a commit to GreyVacuum/Phobos that referenced this pull request Feb 3, 2026
@Starkku Starkku force-pushed the feature/trigger-owner-playeratx branch from 79ba26d to 8610421 Compare February 8, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs testing ⚙️T1 T1 maintainer review is sufficient ❓Unhardcoding / Customization Make something more tweakable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants