-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat: milthm chart support #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
020ea91
eb114a2
78f0c84
52e257d
f4d5e4d
465e635
a30564a
ccb7a30
06da116
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ | |
| "chart_submission": "谱面稿件", | ||
| "chart_submissions": "谱面稿件", | ||
| "choose_chart": "选择谱面", | ||
| "choose_chart_description": "请在此处选择包含 RPE 或 PE 谱面的压缩包(.pez 或 .zip),并且须至少包含谱面、曲目、曲绘文件。", | ||
| "choose_chart_description": "PE / RPE / Rain Editor で作成された譜面のみ対応しています。50MB以下。", | ||
|
||
| "collaboration": "合作邀请", | ||
| "collaborations": "合作邀请", | ||
| "collection_admission": "合集收录申请", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ | |
| "chart_submission": "譜面稿件", | ||
| "chart_submissions": "譜面稿件", | ||
| "choose_chart": "选择谱面", | ||
| "choose_chart_description": "请在此处选择包含 RPE 或 PE 谱面的压缩包(.pez 或 .zip),并且须至少包含谱面、曲目、曲绘文件。", | ||
| "choose_chart_description": "僅支持 PE / RPE / Rain Editor 創作的譜面,不大於 50 MB", | ||
|
||
| "collaboration": "合作邀請", | ||
| "collaborations": "合作邀請", | ||
| "collection_admission": "合集收錄申請", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] There's significant code duplication between the RPE (lines 90-107) and Milthm (lines 119-136) chart processing branches. The BPM calculation logic is identical. Consider extracting this into a shared function to improve maintainability and reduce duplication.