Recyclerview #21
Open
Recyclerview #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V2 changes
chaneylc
requested changes
Feb 28, 2024
Comment on lines
+296
to
+324
| if (cursor.moveToFirst()) { | ||
| for (String header : headerTokens) { | ||
|
|
||
| if (!header.equals(mListId)) { | ||
|
|
||
| final String val = cursor.getString( | ||
| cursor.getColumnIndexOrThrow(header) | ||
| ); | ||
|
|
||
| if (header.equals("color") || header.equals("scan_count") || header.equals("date") | ||
| || header.equals("user") || header.equals("note")) { | ||
| if (header.equals("color")) continue; | ||
| else if (header.equals("scan_count")) auxValues.append("Number of scans"); | ||
| else if (header.equals("date")) auxValues.append("Date"); | ||
| else auxValues.append(header); | ||
| auxValues.append(" : "); | ||
| if (val != null) auxValues.append(val); | ||
| auxValues.append(line_separator); | ||
| } else { | ||
| String value = header + " :\n\t\t"; | ||
| if (val != null) value += val; | ||
| values.add(value); | ||
| } | ||
| } | ||
| } | ||
| cursor.close(); | ||
|
|
||
| adapter.values = values; | ||
| adapter.notifyDataSetChanged(); |
There was a problem hiding this comment.
Improve your recycler view implementation to not require this string builder. Augment your adapter with a model class that has a prefix and value, which are populated here, then sent to the adapter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the valueView StringBuilder implementation with RecyclerView/Adapter