Improve UI/UX across all Android versions (8.0 → 15) - #9
Conversation
Accent selection previously saved a preference and recreated the activity without ever changing the theme. Each accent now applies a Material 3 tonal overlay (night-qualified palettes cover light and dark). Adds a Dynamic (Material You) accent on Android 12+ and removes the values-v31 theme that hardcoded system_neutral1_900 into a DayNight theme, which rendered a near-black background in light mode on Android 12+. Orange uses a dark on-primary color: white on #F57C00 fails WCAG contrast.
…sions The app disabled decor inset fitting and made system bars transparent but never consumed insets, relying on fitsSystemWindows - which Android 15's enforced edge-to-edge ignores. The app bar now pads by the status bar and cutout insets, and each fragment's scroll root pads by the navigation bar inset (clipToPadding=false), so content no longer rests behind the gesture bar. Insets are returned unconsumed so every ViewPager2 page receives them. Also wires ThemeManager.applyAccent into MainActivity and adds a translucent nav-bar scrim on API 26, where dark nav icons are unsupported and a transparent bar would leave white buttons invisible on light content.
Replaces the legacy vector icon (letterboxed by launcher masks since API 26) with an adaptive icon: white ADB glyph foreground over the brand purple background, plus a monochrome layer for Android 13+ themed icons. Opts into the predictive back gesture; no code overrides back handling.
Enforced edge-to-edge is covered by the explicit inset listeners, the foreground service already declares its specialUse subtype, and the connectivity receiver is an exempt system broadcast. Bitmap.getConfig() is nullable in SDK 35 (hardware bitmaps); QR logo rendering falls back to ARGB_8888.
…-UX-against-all-android-versions # Conflicts: # app/build.gradle.kts
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 57b4037de6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| val initialRight = paddingRight | ||
| val initialBottom = paddingBottom | ||
|
|
||
| ViewCompat.setOnApplyWindowInsetsListener(this) { view, windowInsets -> |
There was a problem hiding this comment.
For fragments that ViewPager2 creates after the initial window-insets dispatch, this only registers a listener and never asks the view hierarchy to re-dispatch the current insets. In that scenario (e.g. opening the Statistics or Help tab later), the bottom-padding code may never run until an inset change occurs, leaving content under the gesture/navigation bar despite the new edge-to-edge handling. Call ViewCompat.requestApplyInsets when attached after setting the listener.
Useful? React with 👍 / 👎.
1 participant
Summary
values-v31theme hardcodedsystem_neutral1_900(near-black) into a DayNight theme, rendering dark backgrounds in light mode on Android 12+. Removed.fitsSystemWindows, surviving Android 15's enforced edge-to-edge; content no longer hides under the gesture bar. API 26 gets a nav-bar scrim (no dark-icon support there).Bitmap.getConfig()nullability in QR logo rendering.Testing
assembleDebug,testDebugUnitTest(all pass, incl. updatedAccentColorTest),lintDebug(no errors, no new warnings)main(v1.3.0 release); kept versionCode 6 / 1.3.0 with targetSdk 35