Actually use the async code paths for bulk insert#93
Merged
Conversation
Since its introduction in 045033c, the `sync` argument passed to `BulkInsert()` has always been hardcoded to `false` instead of forwarding the `sync` parameter. As a result, the async code paths for bulk insert in all providers would never be used. This can be confirmed by running code coverage.
PhenX
approved these changes
Feb 8, 2026
Owner
PhenX
left a comment
PhenX
left a comment
There was a problem hiding this comment.
Oh I don't know how I missed it 🤯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since its introduction in 045033c, the
syncargument passed toBulkInsert()has always been hardcoded tofalseinstead of forwarding thesyncparameter.As a result, the async code paths for bulk insert in all providers would never be used. This can be confirmed by running code coverage.