You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the JWT audience contains a UID that does not exist (e.g., a forged or stale token), playerRepository.getPlayerByUid returns null, but loadUserByUsername just forwards that value. AuthenticationTokenFilter then builds a UsernamePasswordAuthenticationToken with the returned user and immediately dereferences userDetails.getAuthorities() (AuthenticationTokenFilter.java lines 67-69), which will throw a NullPointerException and return a 500 instead of a 401. This regression came from the revert; the previous UserDetailsService threw on missing users. The method should raise an authentication error when no player is found instead of returning null.
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 28ed87d.