Texture dumping fixes #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Texture loading, and thereby texture dumping is performed in a secondary thread. Both texture dumping and .fx file loading makes calls to GetDirectoryFile, which returns a pointer to a static buffer. Since these activities can happen at the same time this is a race condition, and sometimes .fx files are overwritten with dumped textures. This change declares the static buffer for GetDirectoryFile as thread local, which fixes the race condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When texture dumping was enabled, it could lead to .fx-files being overwritten. This change fixes the problem and corrects an .ini-file comment.