Replace Detours with MinHook, rebased onto mrexodia's build fixes #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- no more hardcoded paths in the project - more versatile .gitignore (works up to VS2017) - include detours.lib directly in the project - remove x64 platform (Dark Souls is 32 bit) - remove Debug platform (the readme explicitly states this should not be used) - add filters file to categorize source files - added direction to DirectX SDK in the source (at the place it would error)
This change removes an unused library search path from the project settings, and adds some VS2015-specific files to .gitignore .
This change removes the dependency on the proprietary Microsoft Detours and replaces it with MinHook, which is BSD licensed. This will allow making releases in accordance with the GPL. This commit adds a binary release of MinHook. It is a release build by VS2012, made from commit fea705c5e545c1ddd1c791d28c19db82121b9ec9 of https://github.com/RaMMicHaeL/minhook.git .
|
just tested it in my fork; a big size increase to the dll but it seems to work well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of #33, rebased onto #38.