signatures: don't leak an OP_NULL for a '$ =' sigscalarelem #23203
Merged
mauke merged 3 commits intoPerl:bleadfrom Apr 19, 2025
Merged
signatures: don't leak an OP_NULL for a '$ =' sigscalarelem #23203mauke merged 3 commits intoPerl:bleadfrom
mauke merged 3 commits intoPerl:bleadfrom
Conversation
Contributor
|
Is there a regression test we could write for this? |
Contributor
Author
It's already causing the part of the failures described in #23187. |
leonerd
reviewed
Apr 17, 2025
leonerd
approved these changes
Apr 17, 2025
Contributor
leonerd
left a comment
leonerd
left a comment
There was a problem hiding this comment.
Code change LGTM, though I think the comment could be worded slightly clearer for the benefit of future readers.
mauke
force-pushed
the
23187-signature-leak
branch
from
c080708 to
507cff7
Compare
mauke
approved these changes
Apr 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23187