Fix locale handling in Solaris #23199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauke
reviewed
Apr 15, 2025
|
You should run |
Solaris setlocale(3C) returns composite locale prefixed by slash. For example "/en_US.UTF-8/C/C/C/C/C". See man page. We must remove it or this function will think that there is additional empty locale at the beginning of the string and the number of detected locales will not match expected LC_ALL_INDEX_.
|
I have tested it on Solaris with your change just to be sure. All good. And I have updated the AUTHORS file. Thanks ! |
mauke
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solaris setlocale(3C) returns composite locale prefixed by slash. For example "/en_US.UTF-8/C/C/C/C/C". See man page. We must remove it or this function will think that there is additional empty locale at the beginning of the string and the number of detected locales will not match expected LC_ALL_INDEX_.
This is pull request for issue #23195