Skip to content

Conversation

@ori-gold-px
Copy link
Contributor

@ori-gold-px ori-gold-px force-pushed the feature/field-alignments branch from 115c6c0 to 858677a Compare October 30, 2025 20:16
@ori-gold-px ori-gold-px marked this pull request as ready for review November 3, 2025 19:11
@ori-gold-px ori-gold-px requested a review from Copilot November 3, 2025 19:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds multiple enhancements including support for secured PXHD cookies, sensitive request tracking, additional token information, and telemetry improvements. It also updates dependencies to newer patch versions and modernizes the captcha template implementation.

  • Added configuration for secured PXHD cookies and logger severity settings
  • Enhanced telemetry reporting with structured configuration format and request tracking
  • Changed custom parameters from String to Object type for increased flexibility
  • Updated dependencies (Jackson, Commons, SLF4J, Spring, etc.) to newer patch versions
  • Improved first-party proxy error handling and URL validation

Reviewed Changes

Copilot reviewed 29 out of 31 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
web/src/main/java/com/web/Config.java Added px_logger_severity and px_secured_pxhd_enabled configuration options; changed custom params from strings to integers
web/pom.xml Updated slf4j-api from 1.7.25 to 1.7.36
src/main/resources/com/perimeterx/api/blockhandler/templates/captcha_template.mustache Updated captcha template with improved indentation and renamed function (isCaptchaNotLoaded → isContentLoaded)
src/main/java/com/perimeterx/utils/logger/LoggerFactory.java Fixed spacing in ConsoleLogger constructor call
src/main/java/com/perimeterx/models/risk/CustomParameters.java Changed all custom parameter fields from String to Object with documentation comment
src/main/java/com/perimeterx/models/httpmodels/Additional.java Added isSensitiveRoute and additionalTokenInfo fields
src/main/java/com/perimeterx/models/configuration/PXConfiguration.java Added securedPxhdEnabled field; refactored getTelemetryConfig with redaction logic
src/main/java/com/perimeterx/models/configuration/ModuleMode.java Removed duplicate toValue method and setValue method; made fields final and static
src/main/java/com/perimeterx/models/activities/EnforcerTelemetryActivityDetails.java Changed enforcerConfigs to structured format with activeConfig/staticConfig/remoteConfig; added requestId
src/main/java/com/perimeterx/models/activities/CommonActivityDetails.java Added isSensitiveRoute and additionalTokenInfo fields
src/main/java/com/perimeterx/models/PXContext.java Added isSensitiveRequest and additionalTokenInfo tracking; refactored determineIsSensitiveRequest
src/main/java/com/perimeterx/internals/cookie/PXCookie.java Added additionalTokenInfo method to interface
src/main/java/com/perimeterx/internals/cookie/AbstractPXCookie.java Implemented additionalTokenInfo method to extract "add" field from cookie
src/main/java/com/perimeterx/http/PXHttpClient.java Added proper error handling and resource cleanup in sendEnforcerTelemetry
src/main/java/com/perimeterx/api/verificationhandler/DefaultVerificationHandler.java Added Secure flag to pxhd cookie when securedPxhdEnabled is true
src/main/java/com/perimeterx/api/proxy/RemoteServer.java Changed return type to void; added URL length validation, error handling, and resource cleanup
src/main/java/com/perimeterx/api/proxy/DefaultReverseProxy.java Enhanced URL validation with detailed logging and port handling
src/main/java/com/perimeterx/api/blockhandler/templates/TemplateFactory.java Added CAPTCHA_FIRST_PARTY_FILE_PATH to block script URL
src/main/java/com/perimeterx/api/activities/DefaultActivityHandler.java Updated to pass context to EnforcerTelemetryActivityDetails constructor
src/main/java/com/perimeterx/api/activities/BufferedActivityHandler.java Updated to pass context to EnforcerTelemetryActivityDetails constructor
px_metadata.json Updated supported features list and excluded tests; reordered alphabetically
pom.xml Updated multiple dependencies to newer patch versions
ci_files/spec-tests-values.yaml Added retry configuration for tests
ci_files/enforcer-config.json Removed px_filter_by_route; added px_secured_pxhd_enabled
CHANGELOG.md Added entry documenting all changes in this release
.gitignore Added .smarttomcat to ignore list
.github/workflows/* Updated GitHub Actions versions and test configurations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ori-gold-px ori-gold-px merged commit a951644 into dev Nov 5, 2025
9 checks passed
@ori-gold-px ori-gold-px deleted the feature/field-alignments branch November 5, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants