Skip to content

Conversation

@akronim26
Copy link
Contributor

Summary

Replaced the relative paths with the absolute ones to fix the routing issue

Changes Made

Replaced the relative paths with the absolute ones to fix the routing issue. Now the website is working fine!

Checklist

Before submitting this PR, please ensure:

  • Code follows the Solidity feature ban - No inheritance, constructors, modifiers, public/private variables, external library functions, using for directives, or selfdestruct

  • Code follows Design Principles - Readable, uses diamond storage, favors composition over inheritance

  • Code matches the codebase style - Consistent formatting, documentation, and patterns (e.g. ERC20Facet.sol)

  • Code is formatted with forge fmt

  • Existing tests pass - Run tests to be sure existing tests pass.

  • New tests are optional - If you don't provide tests for new functionality or changes then please create a new issue so this can be assigned to someone.

  • All tests pass - Run forge test and ensure everything works

  • Documentation updated - If applicable, update relevant documentation

Make sure to follow the contributing guidelines.

Additional Notes

@netlify
Copy link

netlify bot commented Nov 21, 2025

Deploy Preview for compose-diamonds ready!

Name Link
🔨 Latest commit 05e07c2
🔍 Latest deploy log https://app.netlify.com/projects/compose-diamonds/deploys/69208f26cad47400084eddf7
😎 Deploy Preview https://deploy-preview-213--compose-diamonds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

Coverage Report

Coverage

Metric Coverage Details
Lines 63% 1051/1663 lines
Functions 71% 208/295 functions
Branches 44% 121/273 branches

Last updated: Fri, 21 Nov 2025 16:00:51 GMT for commit 3538028

@github-actions
Copy link

Gas Report

No gas usage changes detected between main and fix/routing.

All functions maintain the same gas costs. ✅

Last updated: Fri, 21 Nov 2025 16:01:13 GMT for commit 3538028

@mudgen
Copy link
Contributor

mudgen commented Nov 21, 2025

@akronim26 Great!

Please run forge update and then commit and push to this pull request to fix this problem:
Screenshot from 2025-11-21 11-07-30

@akronim26
Copy link
Contributor Author

@akronim26 Great!

Please run forge update and then commit and push to this pull request to fix this problem: Screenshot from 2025-11-21 11-07-30

Done @mudgen! Thanks for reviewing.

@mudgen mudgen merged commit f325a04 into Perfect-Abstractions:main Nov 21, 2025
1 check passed
@mudgen
Copy link
Contributor

mudgen commented Nov 21, 2025

Thanks @akronim26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants