-
Notifications
You must be signed in to change notification settings - Fork 60
add 3d diamond to landing page #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for compose-diamonds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I am getting a "oe is not a function" error in landing page.... Nice docusaurus configuration BTW |
|
Thanks @pellyadolfo. I didn't encounter any error while prototyping this landing section. I'll take a look. If you get it again, can you share a screenshot so I can see it? |
|
Thanks, I'll check this out |
|
@pellyadolfo I'm not sure i can reproduce the error you see. i just installed Firefox and i don't see any error on https://compose.diamonds/ You can see a screen recording under. 21.11.2025_09.35.47_REC.mp4I also searched the file change and can't find any |
|
I only get the issue from the laptop of my employer. which uses Firefox. Maybe they have some limited features. No issue from my personal laptop with Firefox. |
|
Good to know. |
|
Yes I checked Firefox log this morning and found this: THREE.WebGLRenderer: A WebGL context could not be created. Reason: WebGL creation failed:
maybe you can check for the flag AllowWebgl2 and display an image otherwise. I suppose is in a few systems only anyway. |
|
Nice find! |
|
Thanks, it give me some juice to dig more. I'll probably add a fallback, if I can't activate the webgl context. It look like WebGL is just not supported on your employer device system (restricts context creation on this system) |
|
You can check if WebGL2 is supported on your device here: https://webglreport.com/?v=2 |

Summary
Changes Made
Checklist
Before submitting this PR, please ensure:
Code follows the Solidity feature ban - No inheritance, constructors, modifiers, public/private variables, external library functions,
using fordirectives, orselfdestructCode follows Design Principles - Readable, uses diamond storage, favors composition over inheritance
Code matches the codebase style - Consistent formatting, documentation, and patterns (e.g. ERC20Facet.sol)
Code is formatted with
forge fmtExisting tests pass - Run tests to be sure existing tests pass.
New tests are optional - If you don't provide tests for new functionality or changes then please create a new issue so this can be assigned to someone.
All tests pass - Run
forge testand ensure everything worksDocumentation updated - If applicable, update relevant documentation
Make sure to follow the contributing guidelines.
Additional Notes