Skip to content

Conversation

@maxnorm
Copy link
Collaborator

@maxnorm maxnorm commented Nov 20, 2025

Summary

Changes Made

Checklist

Before submitting this PR, please ensure:

  • Code follows the Solidity feature ban - No inheritance, constructors, modifiers, public/private variables, external library functions, using for directives, or selfdestruct

  • Code follows Design Principles - Readable, uses diamond storage, favors composition over inheritance

  • Code matches the codebase style - Consistent formatting, documentation, and patterns (e.g. ERC20Facet.sol)

  • Code is formatted with forge fmt

  • Existing tests pass - Run tests to be sure existing tests pass.

  • New tests are optional - If you don't provide tests for new functionality or changes then please create a new issue so this can be assigned to someone.

  • All tests pass - Run forge test and ensure everything works

  • Documentation updated - If applicable, update relevant documentation

Make sure to follow the contributing guidelines.

Additional Notes

@netlify
Copy link

netlify bot commented Nov 20, 2025

Deploy Preview for compose-diamonds ready!

Name Link
🔨 Latest commit b19f2d5
🔍 Latest deploy log https://app.netlify.com/projects/compose-diamonds/deploys/691fa829d22e78000844edca
😎 Deploy Preview https://deploy-preview-210--compose-diamonds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mudgen mudgen merged commit 0580934 into Perfect-Abstractions:main Nov 21, 2025
5 checks passed
@pellyadolfo
Copy link

pellyadolfo commented Nov 21, 2025

I am getting a "oe is not a function" error in landing page.... Nice docusaurus configuration BTW

@maxnorm
Copy link
Collaborator Author

maxnorm commented Nov 21, 2025

Thanks @pellyadolfo.

I didn't encounter any error while prototyping this landing section. I'll take a look. If you get it again, can you share a screenshot so I can see it?

@pellyadolfo
Copy link

this happens in Firefox. In Chrome is ok.

{2A22F61A-8427-4186-BADA-D6A88773F6F9}

@maxnorm
Copy link
Collaborator Author

maxnorm commented Nov 21, 2025

Thanks, I'll check this out

@maxnorm
Copy link
Collaborator Author

maxnorm commented Nov 21, 2025

@pellyadolfo I'm not sure i can reproduce the error you see. i just installed Firefox and i don't see any error on https://compose.diamonds/

You can see a screen recording under.

21.11.2025_09.35.47_REC.mp4

I also searched the file change and can't find any oe reference. Maybe it's the internal function of ThreeJS (WebGL) or GSAP, i'm still looking to reproduce the error you see

@pellyadolfo
Copy link

pellyadolfo commented Nov 23, 2025

I only get the issue from the laptop of my employer. which uses Firefox. Maybe they have some limited features. No issue from my personal laptop with Firefox.

@mudgen
Copy link
Contributor

mudgen commented Nov 23, 2025

Good to know.

@pellyadolfo
Copy link

pellyadolfo commented Nov 24, 2025

Yes I checked Firefox log this morning and found this:

THREE.WebGLRenderer: A WebGL context could not be created. Reason: WebGL creation failed:

  • AllowWebgl2:false restricts context creation on this system. () 5635.4c95a78a.js:2:3989
    Failed to create WebGL context: WebGL creation failed:
  • AllowWebgl2:false restricts context creation on this system. () 5635.4c95a78a.js:2:555639
    THREE.WebGLRenderer: A WebGL context could not be created. Reason: WebGL creation failed:
  • AllowWebgl2:false restricts context creation on this system. () 5635.4c95a78a.js:2:3989
    TypeError: oe is not a function

maybe you can check for the flag AllowWebgl2 and display an image otherwise. I suppose is in a few systems only anyway.

@mudgen
Copy link
Contributor

mudgen commented Nov 24, 2025

Nice find!

@maxnorm
Copy link
Collaborator Author

maxnorm commented Nov 24, 2025

Thanks, it give me some juice to dig more.

I'll probably add a fallback, if I can't activate the webgl context.

It look like WebGL is just not supported on your employer device system (restricts context creation on this system)

@maxnorm
Copy link
Collaborator Author

maxnorm commented Nov 24, 2025

You can check if WebGL2 is supported on your device here: https://webglreport.com/?v=2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants