Docs: Add ERC20StakingFacet example to Design for Composition guide #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for compose-diamonds pending review.Visit the deploys page to approve it
|
Contributor
|
@isihin-3 I looked this over and it looks very good. Well done! |
mudgen
requested changes
Nov 20, 2025
| if (s.stakingStartTimes[msg.sender] == 0) { | ||
| s.stakingStartTimes[msg.sender] = block.timestamp; | ||
| } | ||
Contributor
There was a problem hiding this comment.
Need to emit the ERC20 Transfer event here. For example:
emit Transfer(msg.sender, address(this), _amount);
Contributor
Author
There was a problem hiding this comment.
I did the changes in the latest commit please check it
Contributor
|
Thanks @isihin-3. Good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an "Extending Facets" example to the
Design for Compositionguide. The new section demonstrates, with code snippets.Changes Made
https://compose.diamonds/docs/design/design-for-composition added an "Extending Facets Example" section with explanatory text and code snippets illustrating how to extend an existing facet in a composable way.
Checklist
Before submitting this PR, please ensure:
Code follows the Solidity feature ban - No inheritance, constructors, modifiers, public/private variables, external library functions,
using fordirectives, orselfdestructCode follows Design Principles - Readable, uses diamond storage, favors composition over inheritance
Code matches the codebase style - Consistent formatting, documentation, and patterns (e.g. ERC20Facet.sol)
Code is formatted with
forge fmtExisting tests pass - Run tests to be sure existing tests pass.
New tests are optional - If you don't provide tests for new functionality or changes then please create a new issue so this can be assigned to someone.
All tests pass - Run
forge testand ensure everything worksDocumentation updated - If applicable, update relevant documentation
#202