Skip to content

Conversation

@maxnorm
Copy link
Collaborator

@maxnorm maxnorm commented Nov 8, 2025

Summary

Changes Made

Checklist

Before submitting this PR, please ensure:

  • Code follows the Solidity feature ban - No inheritance, constructors, modifiers, public/private variables, external library functions, using for directives, or selfdestruct

  • Code follows Design Principles - Readable, uses diamond storage, favors composition over inheritance

  • Code matches the codebase style - Consistent formatting, documentation, and patterns (e.g. ERC20Facet.sol)

  • Code is formatted with forge fmt

  • Tests are included - All new functionality has comprehensive tests

  • All tests pass - Run forge test and ensure everything works

  • Documentation updated - If applicable, update relevant documentation

Make sure to follow the CONTRIBUTING.md guidelines.

Additional Notes

@netlify
Copy link

netlify bot commented Nov 8, 2025

Deploy Preview for compose-diamonds failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit 296aa3e
🔍 Latest deploy log https://app.netlify.com/projects/compose-diamonds/deploys/690fae1dee6cc000085594e1

@maxnorm maxnorm merged commit 0781ff2 into Perfect-Abstractions:main Nov 8, 2025
5 of 9 checks passed
@github-actions
Copy link

github-actions bot commented Nov 8, 2025

Coverage Report

Coverage

Metric Coverage Details
Lines 58% 850/1453 lines
Functions 66% 160/244 functions
Branches 40% 102/254 branches

Last updated: Sat, 08 Nov 2025 20:55:12 GMT for commit 296aa3e

@github-actions
Copy link

github-actions bot commented Nov 8, 2025

Gas Report

No gas usage changes detected between main and ci.

All functions maintain the same gas costs. ✅

Last updated: Sat, 08 Nov 2025 20:55:35 GMT for commit 296aa3e

@maxnorm maxnorm deleted the ci branch November 23, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant