feat: implement ERC-20 Permit extension (EIP-2612) #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add permit() function for gasless approvals - Add nonces mapping for replay attack prevention - Add DOMAIN_SEPARATOR for EIP-712 compliance - Add initializeERC20() for token metadata setup - Follow Compose diamond pattern and coding standards - Full EIP-2612 specification compliance Fixes Perfect-Abstractions#7
- Resolved conflicts between feature branch and main - Kept EIP-2612 nonces mapping and functions - Incorporated improved documentation from main - Maintained all EIP-2612 permit functionality
Contributor
|
@panditdhamdhere, wow, this looks great! Good job. Right now I can't merge it because there are merge conflicts (because comments were added). Can you please fix the conflicts so I can merge your code? Please remove the |
Contributor
|
Merged. Thank you |
JackieXu
pushed a commit
to JackieXu/Compose
that referenced
this pull request
Nov 6, 2025
…re/erc20-permit-extension feat: implement ERC-20 Permit extension (EIP-2612)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7