docs: add NatSpec documentation for ERC20 and ERC721 libraries #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudgen
reviewed
Oct 18, 2025
mudgen
reviewed
Oct 18, 2025
| // of diamond storage identifier | ||
|
|
||
|
|
||
| /// @notice Storage slot identifier, defined using keccak256 hash of the library namespace. |
Contributor
There was a problem hiding this comment.
It is called a "diamond storage identifier", not a namespace.
Collaborator
Author
There was a problem hiding this comment.
Changes made. Thank you
Contributor
|
Looking really good, almost there. |
Contributor
|
Thanks @Haroldwonder! |
JackieXu
pushed a commit
to JackieXu/Compose
that referenced
this pull request
Nov 6, 2025
…spec-libs docs: add NatSpec documentation for ERC20 and ERC721 libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.