Add NatSpec documentation to ERC20 contract #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudgen
reviewed
Oct 16, 2025
src/ERC20/ERC20/ERC20.sol
Outdated
|
|
||
| /** | ||
| * @title ERC20 | ||
| * @notice A minimal ERC-20 token implementation using ERC-8042 diamond storage. |
Contributor
There was a problem hiding this comment.
This is not a minimal implementation of ERC20. It is a full implementation of the ERC20 standard. It just looks minimal because other implementations are bloated and spaghetti code.
Contributor
|
@Haroldwonder Thanks very much for this pull request. I made some changes that causes conflicts. Can you fix these conflicts so I can merge? |
Collaborator
Author
|
@mudgen Open pull request updated, Nick. Happy to contribute. |
Contributor
|
Thanks! Still have merge conflicts. I'll stop changing the file, sorry about that. |
# Conflicts: # src/ERC20/ERC20/ERC20Facet.sol
Collaborator
Author
|
I have pushed now without conflicts |
Contributor
|
Merged, thank you! Congratulations on making the first contribution to this library! |
JackieXu
pushed a commit
to JackieXu/Compose
that referenced
this pull request
Nov 6, 2025
…rc20-natspec Add NatSpec documentation to ERC20 contract
JackieXu
pushed a commit
to JackieXu/Compose
that referenced
this pull request
Nov 6, 2025
Feat/improve ci
gsknnft
added a commit
to gsknnft/Compose
that referenced
this pull request
Nov 18, 2025
…ent-sharded-registry Implement sharded Diamond Loupe with SSTORE2 snapshots for O(1) enumeration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.